[SPARK-54607][CORE] Remove unused method toStringHelper from AbstractFetchShuffleBlocks.java
#53341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toStringHelper from AbstractFetchShuffleBlocks.javatoStringHelper from AbstractFetchShuffleBlocks.java
| } | ||
|
|
||
| // checkstyle.off: RegexpSinglelineJava | ||
| public ToStringBuilder toStringHelper() { |
Member
There was a problem hiding this comment.
IIRC, I didn't delete this intentionally because this is public method of public class, @LuciferYang .
Member
There was a problem hiding this comment.
I'm wondering if this is safe and you are sure that AbstractFetchShuffleBlocks is not referenced by any case outside of Apache Spark? What about Apache Celeborn or Apache Uniffle?
Contributor
Author
There was a problem hiding this comment.
Judging from GitHub's search results, apart from Spark, no other code repositories, including Apache Celeorn and Apache Uniffle, are using AbstractFetchShuffleBlocks.
dongjoon-hyun
approved these changes
Dec 6, 2025
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM for Apache Spark 4.2.0.
Contributor
Author
|
Merged into master. Thanks @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to remove the unused method
toStringHelperfromAbstractFetchShuffleBlocks.javabecause it is no longer used after #51572.Why are the changes needed?
Code cleanup.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No