Skip to content

[SPARK-54607][CORE] Remove unused method toStringHelper from AbstractFetchShuffleBlocks.java #53341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 1 commit into from
Closed

[SPARK-54607][CORE] Remove unused method toStringHelper from AbstractFetchShuffleBlocks.java #53341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions ...e/src/main/java/org/apache/spark/network/shuffle/protocol/AbstractFetchShuffleBlocks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@

import io.netty.buffer.ByteBuf;

import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;
import org.apache.spark.network.protocol.Encoders;

/**
Expand All @@ -44,15 +42,6 @@ protected AbstractFetchShuffleBlocks(
this.shuffleId = shuffleId;
}

// checkstyle.off: RegexpSinglelineJava
public ToStringBuilder toStringHelper() {
Copy link
Member

@dongjoon-hyun dongjoon-hyun Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I didn't delete this intentionally because this is public method of public class, @LuciferYang .

Copy link
Member

@dongjoon-hyun dongjoon-hyun Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this is safe and you are sure that AbstractFetchShuffleBlocks is not referenced by any case outside of Apache Spark? What about Apache Celeborn or Apache Uniffle?

Copy link
Contributor Author

@LuciferYang LuciferYang Dec 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from GitHub's search results, apart from Spark, no other code repositories, including Apache Celeorn and Apache Uniffle, are using AbstractFetchShuffleBlocks.

return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
.append("appId", appId)
.append("execId", execId)
.append("shuffleId", shuffleId);
}
// checkstyle.on: RegexpSinglelineJava

/**
* Returns number of blocks in the request.
*/
Expand Down