[SPARK-54253][Geo][SQL] Add a guarding config for geospatial support #53009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Nice! Thank you so much for proposing this new configuration, @uros-db .
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/st/stExpressions.scala
Outdated
Show resolved
Hide resolved
uros-db
commented
Nov 12, 2025
Contributor
Author
uros-db
left a comment
There was a problem hiding this comment.
I'm converting this PR to draft while I figure out how to enforce the config in testing for Connect (e.g. ArrowEncoderSuite) and clear those failures. Not sure how to do this at the moment, because static SQL config values can't be changed, and modifying testConfigs in SparkConnectServerUtils doesn't help either because isTesting stays false and config value is not propagated between server & client.
Member
|
Gentle ping, @uros-db . If there is no way, please turn it |
dillitz
reviewed
Nov 14, 2025
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala
Outdated
Show resolved
Hide resolved
milastdbx
reviewed
Nov 14, 2025
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/GeographyType.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/st/stExpressions.scala
Outdated
Show resolved
Hide resolved
.../client/jvm/src/test/scala/org/apache/spark/sql/connect/client/arrow/ArrowEncoderSuite.scala
Outdated
Show resolved
Hide resolved
holdenk
reviewed
Nov 14, 2025
sql/api/src/main/scala/org/apache/spark/sql/types/GeometryType.scala
Outdated
Show resolved
Hide resolved
holdenk
reviewed
Nov 14, 2025
sql/api/src/main/scala/org/apache/spark/sql/types/GeometryType.scala
Outdated
Show resolved
Hide resolved
Member
|
Please let me know when you are ready, @uros-db . |
cloud-fan
reviewed
Nov 18, 2025
| */ | ||
| def geospatialTypeWithSrid(sourceType: DataType, srid: Expression): DataType = { | ||
| sourceType match { | ||
| case _ if !SQLConf.get.geospatialEnabled => |
Contributor
There was a problem hiding this comment.
is it a narrow waist for geo functionalities?
Contributor
Author
There was a problem hiding this comment.
Yes, this is very narrow wrt. geo. It's exclusively used in ST expressions (currently only 1 expression, but will be re-used in a few more) to determine the resulting dataType.
cloud-fan
reviewed
Nov 18, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/st/stExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 18, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/st/stExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 18, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 18, 2025
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 18, 2025
cloud-fan
reviewed
Nov 18, 2025
cloud-fan
reviewed
Nov 19, 2025
sql/core/src/test/scala/org/apache/spark/sql/STExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Nov 19, 2025
Contributor
Author
|
Hi folks all checks are good here, and I marked the PR ready as for review. @cloud-fan @dongjoon-hyun @holdenk |
Contributor
|
thanks, merging to master/4.1! |
cloud-fan
pushed a commit
that referenced
this pull request
Nov 19, 2025
### What changes were proposed in this pull request? Introduce a new SQL config for controlling the geospatial feature: ``` spark.sql.geospatial.enabled ``` The default value is `false`, and enabled only in testing. ### Why are the changes needed? Guard the geospatial feature until it's fully finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added appropriate unit tests to confirm that the config is effective: - `STExpressionsSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53009 from uros-db/geo-config. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d299684) Signed-off-by: Wenchen Fan <[email protected]>
Member
|
Thank you so much, @uros-db , @cloud-fan and all. |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? Introduce a new SQL config for controlling the geospatial feature: ``` spark.sql.geospatial.enabled ``` The default value is `false`, and enabled only in testing. ### Why are the changes needed? Guard the geospatial feature until it's fully finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added appropriate unit tests to confirm that the config is effective: - `STExpressionsSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53009 from uros-db/geo-config. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
pushed a commit
that referenced
this pull request
Dec 4, 2025
…ig in Spark Connect ### What changes were proposed in this pull request? A new SQL config (`spark.sql.geospatial.enabled`) was introduced as part of #53009. However, the original PR didn't fully gate geospatial functionality, so this PR also forbids geo dataframes in Spark Connect. ### Why are the changes needed? Guard the geospatial feature until it's fully finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added appropriate unit tests to confirm that the config is effective: - `GeographyConnectDataFrameSuite` - `GeometryConnectDataFrameSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53259 from uros-db/geo-config_connect_tests. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
pushed a commit
that referenced
this pull request
Dec 4, 2025
…ig in Spark Connect ### What changes were proposed in this pull request? A new SQL config (`spark.sql.geospatial.enabled`) was introduced as part of #53009. However, the original PR didn't fully gate geospatial functionality, so this PR also forbids geo dataframes in Spark Connect. ### Why are the changes needed? Guard the geospatial feature until it's fully finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added appropriate unit tests to confirm that the config is effective: - `GeographyConnectDataFrameSuite` - `GeometryConnectDataFrameSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53259 from uros-db/geo-config_connect_tests. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 38d6010) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce a new SQL config for controlling the geospatial feature:
The default value is
false, and enabled only in testing.Why are the changes needed?
Guard the geospatial feature until it's fully finished.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added appropriate unit tests to confirm that the config is effective:
STExpressionsSuiteWas this patch authored or co-authored using generative AI tooling?
No.