[GH-3200] Serialize empty Geography LineStrings as valid WKB - #3205
Closed
jiayuasu wants to merge 1 commit into
Closed
[GH-3200] Serialize empty Geography LineStrings as valid WKB#3205jiayuasu wants to merge 1 commit into
jiayuasu wants to merge 1 commit into
Conversation
Member
Author
|
Closing as superseded by #3195. The merged implementation now writes empty geography LineStrings as valid zero-coordinate WKB and also handles S2 singleton polylines by emitting an OGC-valid two-coordinate LineString, with round-trip coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes [BUG]: Empty Geography LineStrings produce malformed WKB #3200.What changes were proposed in this PR?
SinglePolylineGeography.LINESTRING EMPTYWKB instead of a header-only, malformed byte sequence.WKBGeography.fromS2Geography()to round-trip an empty LineString through JTS while preserving its SRID.The malformed WKB was discovered while reviewing #3195. This PR isolates the pre-existing serialization defect from the
ST_MakeLinefeature. It does not define the separate behavior forST_MakeLine(EMPTY, non-empty), which is tracked by #3202.How was this patch tested?
010200000000000000.Did this PR include necessary documentation updates?