[GH-3177] Add Geography support for ST_MakeLine - #3195
Merged
Conversation
jiayuasu
marked this pull request as ready for review
July 28, 2026 06:15
jiayuasu
force-pushed
the
feature/geography-make-line
branch
from
July 29, 2026 05:42
caf40b1 to
d99dd55
Compare
This was referenced Jul 29, 2026
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Add Geography support for ST_MakeLine #3177.What changes were proposed in this PR?
ST_MakeLinein Spark and Flink for Point, MultiPoint, and LineString inputs. The array and aggregate forms remain Geometry-only.ST_AsText,ST_AsEWKT,ST_NPoints, and WKB round trips consistent with the stored coordinates.ST_AsEWKT(Geography)now uses the stored WKB/JTS representation for all Geography values instead of the fixed-precision S2 writer, so it no longer truncates ordinary input coordinates.The S2 operational view can canonicalize internal adjacent duplicates, while SQL structural accessors continue to report the stored WKB coordinates. No function-specific provenance is stored in
WKBGeography, and this PR has no net change toWKBGeography.java.Pre-existing empty-input behavior is outside this change: combining an empty Point or LineString with a non-empty input can still attempt to construct a one-point JTS LineString and fail.
ST_Envelopeon an empty Point is also unchanged.How was this patch tested?
ST_MakeLineinput.git diff --checkpassed.Did this PR include necessary documentation updates?
v1.9.1.ST_MakeLineAPI pages are updated.