Skip to content

Improve wget update command#3723

Merged
csantanapr merged 2 commits intoapache:masterfrom
chetanmeh:wget-fix
Jun 4, 2018
Merged

Improve wget update command#3723
csantanapr merged 2 commits intoapache:masterfrom
chetanmeh:wget-fix

Conversation

@chetanmeh
Copy link
Member

@chetanmeh chetanmeh commented Jun 4, 2018

Improves the changes done in #3715 by adding space after wget. It also removed unused build.sh which was a leftover post #3613

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@chetanmeh chetanmeh mentioned this pull request Jun 4, 2018
21 tasks
@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #3723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3723   +/-   ##
=======================================
  Coverage   75.05%   75.05%           
=======================================
  Files         127      127           
  Lines        6041     6041           
  Branches      391      391           
=======================================
  Hits         4534     4534           
  Misses       1507     1507

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714c707...87343b1. Read the comment docs.

@csantanapr csantanapr self-assigned this Jun 4, 2018
@csantanapr csantanapr merged commit fbf22c5 into apache:master Jun 4, 2018
@chetanmeh chetanmeh deleted the wget-fix branch June 6, 2018 05:05
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
* Add space in command after wget common/scala
* Remove unused build.sh file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants