Update wget to fix travis builds#3715
Merged
rabbah merged 1 commit intoapache:masterfrom May 31, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3715 +/- ##
=========================================
Coverage ? 75.05%
=========================================
Files ? 127
Lines ? 6038
Branches ? 390
=========================================
Hits ? 4532
Misses ? 1506
Partials ? 0Continue to review full report at Codecov.
|
rabbah
approved these changes
May 31, 2018
csantanapr
reviewed
May 31, 2018
|
|
||
| RUN apk upgrade --update && \ | ||
| apk add --update libstdc++ curl ca-certificates bash sed && \ | ||
| apk add --update libstdc++ curl ca-certificates bash sed wget&& \ |
Member
There was a problem hiding this comment.
Hum no problem with not having a space in wget&& ?
Member
Author
There was a problem hiding this comment.
Looks like in hurry I forgot to add a space. However it does works and wget gets updated
(12/13) Installing sed (4.4-r0)
(13/13) Installing wget (1.19.5-r0)
Executing busybox-1.26.2-r11.trigger
Executing ca-certificates-20161130-r2.trigger
Would fix this in a new PR
whereisaaron
added a commit
to whereisaaron/awscli
that referenced
this pull request
Jun 16, 2018
The busybox imitation wget in alpine 3.6 appears to have problems with important AWS contexts, like `wget -O - -q http://169.254.169.254/2016-09-02/meta-data/instance-id` An effective workaround is to include the alpine real 'wget' package. This patch does that. (Alternatively, reverting to alpine 3.5 apparently also fixes the busybox 'wget') kubernetes-retired/kube-aws#1369 gliderlabs/docker-alpine#292 gliderlabs/docker-alpine#344 https://git.busybox.net/busybox/commit/?id=a6f8651911716d1d1624712eb19e4f3608767c7e apache/openwhisk#3715 (It would be nice to have version tags in the 'awscli' repo so people could e.g. (a) revert to the working release, or (b) if this full wget breaks for someone who was counting of some property of the busybox wget.)
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Invoker docker build failure by updating the
wgetversionDescription
Travis builds are currently failing (both master and PRs) due to failure in invoker docker build with following errors
However the build passes locally and there seems to be no error with storage.googleapis.com SSL as seen here. Looks like wget shipped with alpine:3.6 is old has some issues and updating that resolves the issue for us.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: