Skip to content

nshlib/cmd_dd: Retry if read() was interrupted#2837

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
JianyuWang0623:br_wjy_cmd_dd_read_sigchld_241111
Nov 11, 2024
Merged

nshlib/cmd_dd: Retry if read() was interrupted#2837
xiaoxiang781216 merged 1 commit into
apache:masterfrom
JianyuWang0623:br_wjy_cmd_dd_read_sigchld_241111

Conversation

@JianyuWang0623
Copy link
Copy Markdown
Contributor

@JianyuWang0623 JianyuWang0623 commented Nov 10, 2024

Summary

nshlib/cmd_dd: Retry if read() was interrupted

  • Without this patch
nsh> ls /etc/group | dd | dd
sh [13:100]
sh [14:100]
nsh: dd: read failed: 4
nsh>
  • With this patch
nsh> ls | dd | dd | dd | dd | dd
sh [4:100]
sh [5:100]
sh [6:100]
sh [7:100]
sh [8:100]
/:
 bin/
 dev/
 etc/
 proc/
 tmp/
 var/
nsh>

Link: #2833 (same reason), #2737 (nsh pipeline)

Impact

nshlib/cmd_dd

Testing

  • nsh:sim with pipeline enabled
  • NuttX CI

Without this patch

  nsh> ls /etc/group | dd | dd
  sh [13:100]
  sh [14:100]
  nsh: dd: read failed: 4
  nsh>

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 27b5021 into apache:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants