Skip to content

nshlib/cmd_cat: Retry if nsh_read() was interrupted by a signal#2833

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
JianyuWang0623:br_wjy_cmd_cat_read_EINTR_241108
Nov 10, 2024
Merged

nshlib/cmd_cat: Retry if nsh_read() was interrupted by a signal#2833
xiaoxiang781216 merged 1 commit into
apache:masterfrom
JianyuWang0623:br_wjy_cmd_cat_read_EINTR_241108

Conversation

@JianyuWang0623
Copy link
Copy Markdown
Contributor

@JianyuWang0623 JianyuWang0623 commented Nov 8, 2024

Summary

nshlib/cmd_cat: Retry if nsh_read() was interrupted by a signal.
When read from stdio of child process through pipe, SIGCHLD received if child exits.

Impact

nshlib/cmd_cat.

Testing

  1. Selftest
ls | cat | cat | cat | cat
  1. Github CI

When read from stdio of child process through pipe, SIGCHLD received if child exits.

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@nuttxpr
Copy link
Copy Markdown

nuttxpr commented Nov 8, 2024

[Experimental Bot, please feedback here]

No. This PR summary lacks crucial details. While it states what changed, it doesn't explain why retrying on a signal interrupt is necessary for nsh_read(), specifically in the context of pipes and child processes. The impact section is also too brief, simply restating the affected file. It needs to address the impact questions listed in the requirements. Finally, relying solely on GitHub CI for testing is insufficient. Local testing details (host and target) and example logs before/after the change are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants