Stop returning null in SearchGroup#merge - #16088
Merged
javanna merged 4 commits intoMay 21, 2026
Merged
Conversation
Returning null can cause issues down the line once we move to using collector managers and leverage the merge method for results reduction. This commit replaces the null return type with an empty list. Relates to apache#15574
javanna
force-pushed
the
enhancement/search_group_merge_not_null
branch
from
May 21, 2026 07:52
ea5c481 to
e5f37eb
Compare
javanna
added a commit
that referenced
this pull request
May 21, 2026
Returning null can cause issues down the line once we move to using collector managers and leverage the merge method for results reduction. This commit replaces the null return type with an empty list. Relates to #15574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning null can cause issues down the line once we move to using collector managers and leverage the merge method for results reduction.
This commit replaces the null return type with an empty list.
Relates to #15574