Introduce FirstPassGroupingCollectorManager - #15574
Merged
Merged
Conversation
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Signed-off-by: Binlong Gao <gbinlong@amazon.com> Format code Signed-off-by: Binlong Gao <gbinlong@amazon.com>
gaobinlong
force-pushed
the
firstPassManager
branch
from
March 30, 2026 13:52
82f9003 to
d40d5d5
Compare
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
Author
|
Hi @dweiss , mind taking a look at this PR? I think it's simple. |
javanna
reviewed
Apr 20, 2026
javanna
left a comment
Contributor
There was a problem hiding this comment.
Thanks @gaobinlong , I left some comments!
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
|
Hi @gaobinlong I am ready to do another round of review on this PR if you have time to address the comments. Thanks! |
Contributor
Author
Addressed all comments yet, please help to review, thanks! |
javanna
reviewed
May 19, 2026
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
javanna
reviewed
May 20, 2026
javanna
left a comment
Contributor
There was a problem hiding this comment.
Last round of review, some minor comments.
javanna
added a commit
that referenced
this pull request
May 21, 2026
Returning null can cause issues down the line once we move to using collector managers and leverage the merge method for results reduction. This commit replaces the null return type with an empty list. Relates to #15574
javanna
added a commit
that referenced
this pull request
May 21, 2026
Returning null can cause issues down the line once we move to using collector managers and leverage the merge method for results reduction. This commit replaces the null return type with an empty list. Relates to #15574
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
javanna
requested changes
May 22, 2026
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
javanna
reviewed
May 28, 2026
javanna
left a comment
Contributor
There was a problem hiding this comment.
left a couple more minor comments, this is really close, thanks!
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
javanna
pushed a commit
that referenced
this pull request
Jun 3, 2026
This pr introduces `FirstPassGroupingCollectorManager` and switches `TestGrouping` and `BaseGroupSelectorTestCase` to use search concurrency and move away from the deprecated `search(Query, Collector)` method. Relates to #12892. Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
|
Thanks @gaobinlong , merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr introduces FirstPassGroupingCollectorManager and switches TestGrouping and BaseGroupSelectorTestCase to use search concurrency and move away from the deprecated search(Query, Collector) method.
Relates to #12892.