Open
Conversation
Contributor
Author
|
@leekeiabstraction PTAL 🙏 |
Merged
Contributor
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR! Left some comments PTAL
Contributor
Author
|
@leekeiabstraction Ty for the review. Addressed comment about py configs |
Contributor
leekeiabstraction
left a comment
There was a problem hiding this comment.
Left comment, thank you for the update!
Contributor
Author
|
@luoyuxia Sorry to bother, but we might need your help here. |
26668a3 to
3a69e30
Compare
3a69e30 to
c8cc45b
Compare
Contributor
Author
|
@leekeiabstraction @luoyuxia Ty for the review |
leekeiabstraction
approved these changes
Feb 15, 2026
Contributor
leekeiabstraction
left a comment
There was a problem hiding this comment.
LGTM, TY for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OffsetQuery(C++) andOffsetType(Python) toOffsetSpecwith factory methods, matching the Java client APIlist_partition_infoswith optional partial partition spec filter to Python and C++ clientsbootstrap_servers,writer_batch_size, etc.) matching C++/Rust field names