Conversation
|
@luoyuxia This is a first draft, can you check if this structuring is OK before I move onto polishing / port over the content from existing docs? |
88dfc65 to
618109b
Compare
There was a problem hiding this comment.
Pull request overview
Adds a Docusaurus-based documentation website under website/ to host client documentation (Rust/Python/C++) for the fluss-rust repository, along with assets, styling, and sidebar/navigation configuration.
Changes:
- Introduces a Docusaurus site (config, sidebar, TypeScript config, build scripts, dependencies).
- Adds client documentation pages for Rust, Python, and C++ plus developer-guide content.
- Adds website branding assets and custom CSS aligned with the main Fluss site; updates
.gitignorefor website build artifacts.
Reviewed changes
Copilot reviewed 38 out of 42 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
.gitignore |
Ignores Docusaurus build/artifact directories and fixes CMake ignore indentation. |
website/babel.config.js |
Adds Babel preset config for Docusaurus. |
website/docusaurus.config.ts |
Core Docusaurus site configuration (navbar, prism, baseUrl, editUrl, etc.). |
website/package.json |
Adds Node dependencies/scripts for building and serving the docs site. |
website/sidebars.ts |
Defines sidebar structure (User Guide autogenerated + Developer Guide). |
website/src/css/custom.css |
Custom styling to match main Fluss website. |
website/static/img/logo/png/colored_logo.png |
Adds logo image asset. |
website/static/img/logo/svg/colored_logo.svg |
Adds SVG logo asset (includes ASF header). |
website/static/img/logo/fluss_favicon.svg |
Adds favicon SVG asset (includes ASF header). |
website/tsconfig.json |
Adds TS config extending Docusaurus defaults. |
website/docs/index.md |
Site landing page (client overview and guide structure). |
website/docs/user-guide/_category_.json |
Creates “User Guide” doc category metadata. |
website/docs/user-guide/rust/_category_.json |
Creates “Rust” subcategory metadata. |
website/docs/user-guide/rust/installation.md |
Rust installation instructions and feature flags. |
website/docs/user-guide/rust/example.md |
Rust quickstart example. |
website/docs/user-guide/rust/configuration.md |
Rust client configuration reference. |
website/docs/user-guide/rust/admin-operations.md |
Rust admin API examples. |
website/docs/user-guide/rust/log-tables.md |
Rust log-table usage guide. |
website/docs/user-guide/rust/primary-key-tables.md |
Rust primary-key (KV) table usage guide. |
website/docs/user-guide/rust/partitioned-tables.md |
Rust partitioned table usage guide. |
website/docs/user-guide/rust/data-types.md |
Rust data type mapping reference. |
website/docs/user-guide/python/_category_.json |
Creates “Python” subcategory metadata. |
website/docs/user-guide/python/installation.md |
Python bindings installation/build-from-source guide. |
website/docs/user-guide/python/example.md |
Python quickstart example. |
website/docs/user-guide/python/configuration.md |
Python client configuration reference. |
website/docs/user-guide/python/admin-operations.md |
Python admin API examples. |
website/docs/user-guide/python/log-tables.md |
Python log-table usage guide. |
website/docs/user-guide/python/primary-key-tables.md |
Python primary-key (KV) table usage guide. |
website/docs/user-guide/python/partitioned-tables.md |
Python partitioned table usage guide. |
website/docs/user-guide/python/data-types.md |
Python data type mapping reference. |
website/docs/user-guide/cpp/_category_.json |
Creates “C++” subcategory metadata. |
website/docs/user-guide/cpp/installation.md |
C++ bindings build/install instructions. |
website/docs/user-guide/cpp/example.md |
C++ quickstart example. |
website/docs/user-guide/cpp/configuration.md |
C++ configuration/error-handling guide. |
website/docs/user-guide/cpp/admin-operations.md |
C++ admin API examples. |
website/docs/user-guide/cpp/log-tables.md |
C++ log-table usage guide. |
website/docs/user-guide/cpp/primary-key-tables.md |
C++ primary-key (KV) table usage guide. |
website/docs/user-guide/cpp/partitioned-tables.md |
C++ partitioned table usage guide. |
website/docs/user-guide/cpp/data-types.md |
C++ data type mapping reference. |
website/docs/developer-guide/_category_.json |
Creates “Developer Guide” doc category metadata. |
website/docs/developer-guide/contributing.md |
Contributor/dev setup instructions for repo. |
website/docs/developer-guide/release.md |
Release process documentation for clients. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@leekeiabstraction Thanks for the great work. It look well! |
618109b to
f2f83f4
Compare
|
@luoyuxia @fresh-borzoni Appreciate your reviews here |
|
I will update this again after #302 is merged |
f2f83f4 to
7f52dac
Compare
|
Rebased and updated doc according to latest API changes, appreciate a review here @luoyuxia @fresh-borzoni |
7f52dac to
abe9327
Compare
|
Updated doc to include changes from unsubscribe APIs as well. |
fresh-borzoni
left a comment
There was a problem hiding this comment.
@leekeiabstraction Ty for the PR. Took a while to take a look
Left some comments. PTAL.
I will address code inconsistencies and let you know about some of the comments. And then we'll run another round of review, probably we'll spot something else.
|
Also we may wish to specify default precision for Timestamps - it's 6. It might be important. |
|
@leekeiabstraction I created #313 to address inconsistencies found while reviewing doc |
There was a problem hiding this comment.
@leekeiabstraction Thanks for the great work. It looks good to me overall. For any document miss, we can add in following pr. Let's just merge it before it becomes too big...
Few more comments here:
- Add a readme for website to include how to build, just like java repo?
- seems read me is generate , maybe we can just remove readme now since website already include it? It's hard to maintail two copy of context although one is just generated.
luoyuxia
left a comment
There was a problem hiding this comment.
After build the website, left more comments.
Btw, with the website, our fluss-rust project looks more attractive.
# Conflicts: # bindings/python/README.md # docs/rust-client.md # Conflicts: # docs/rust-client.md
…isn't handle by server. Formatting.
abe9327 to
e8cdd82
Compare
|
Thank you both for the diligent and tireless reviews 🙏! I've addressed most comments. Let's get this merged and we can address further changes in smaller PRs. |
luoyuxia
left a comment
There was a problem hiding this comment.
@fresh-borzoni Hi, do you have further comments.
|
No comments, we'd better merge |
luoyuxia
left a comment
There was a problem hiding this comment.
Thank @leekeiabstraction . LGTM to me
Purpose
Linked issue: close #299 #284
Brief change log
Example on how it looks: