Skip to content

clean up ClientSavingsIntegrationTest#762

Closed
vorburger wants to merge 3 commits intoapache:developfrom
vorburger:FINERACT-852_ClientSavingsIntegrationTest_reformat
Closed

clean up ClientSavingsIntegrationTest#762
vorburger wants to merge 3 commits intoapache:developfrom
vorburger:FINERACT-852_ClientSavingsIntegrationTest_reformat

Conversation

@vorburger
Copy link
Member

@vorburger vorburger commented Apr 13, 2020 •
edited
Loading

@vorburger
Copy link
Member Author

vorburger commented Apr 13, 2020

This failed due to what #764 will fixed (work around, deactivating test); let's rebase this once that is in.

This was referenced Apr 13, 2020
Merged
Merged
@xurror
Copy link
Contributor

xurror commented Apr 14, 2020

This is still failing

@awasum
Copy link
Contributor

awasum commented Apr 15, 2020 •
edited
Loading

#764 has been merged. lets run this or rebase with develop and see.

@awasum awasum closed this Apr 15, 2020
@awasum awasum reopened this Apr 15, 2020
@vorburger vorburger force-pushed the FINERACT-852_ClientSavingsIntegrationTest_reformat branch from 7d6c39a to 5728b12 Compare April 17, 2020 16:43
@vorburger vorburger marked this pull request as draft April 17, 2020 17:40
@vorburger
Copy link
Member Author

vorburger commented Apr 17, 2020

This one seems to have failed for other reasons than #761, perhaps my "cleanup" here wasn't all that clean? 😄 I need to look more into this, not right now but some other time, unless anyone else is interested in helping with this (this should, hopefully, be a much simpler just trivial mistake?):

> Task :integrationTest

org.apache.fineract.integrationtests.ClientSavingsIntegrationTest > testSavingsAccountPostInterestOnLastDayWithdrawalWithOverdraft FAILED
    java.lang.AssertionError at ClientSavingsIntegrationTest.java:1383

org.apache.fineract.integrationtests.ClientSavingsIntegrationTest > testSavingsAccountPostInterestOnLastDayWithOverdraft FAILED
    java.lang.AssertionError at ClientSavingsIntegrationTest.java:1042

@vorburger vorburger force-pushed the FINERACT-852_ClientSavingsIntegrationTest_reformat branch from 5728b12 to af1eafc Compare May 5, 2020 21:02
@vorburger
Copy link
Member Author

vorburger commented Jun 1, 2020

I want to leave this for anyone else interested to work on, and am "abandoning" this PR (and have un-assigned FINERACT-891; feel free to pick it up).

@vorburger vorburger closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vorburger @xurror @awasum