set fineract_tenants_* more nicely in docker-compose.yml#759
Merged
vorburger merged 2 commits intoapache:developfrom Apr 15, 2020
Merged
set fineract_tenants_* more nicely in docker-compose.yml#759vorburger merged 2 commits intoapache:developfrom
vorburger merged 2 commits intoapache:developfrom
Conversation
We can use environment variables instead of system properties. We originally had to use system properties and could not use environment variables, because these used to read by Tomcat, but since the switch to Hikari in FINERACT-796 these are read by Spring Boot instead of Tomcat, so we can now use system properties. This both "looks nicer" and is useful e.g. for FINERACT-881.
be1e7ee to
8cfdfd5
Compare
These are the default values, from jdbc.properties, only added for clarity and to make it obvious that they need to be changed e.g. for FINERACT-762. The different formats and naming conventions are a little bit of a mess, but changing them now leads to backwards incompatibility, so for now let's leave as is; possible clean up later in FINERACT-889.
Member
Author
|
This failed due to what #762 will fix (work around, deactivating test); let's rebase this once that is in. @xurror you're probably interested in this change, see my comment in FINERACT-881. |
Contributor
|
#764 has been merged. lets run this or rebase with develop and see. |
Contributor
|
This is now passing. Do you want to merge this @vorburger ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use environment variables instead of system properties.
We originally had to use system properties and could not use environment variables, because these used to read by Tomcat, but since the switch to Hikari in FINERACT-796 these are read by Spring Boot instead of Tomcat, so we can now use system properties.
This both "looks nicer" and is useful e.g. for FINERACT-881.