Skip to content

[ISSUE #4266]InterruptedExceptions should never be ignored[connectors] #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxsm merged 3 commits into from
Aug 2, 2023
Merged

[ISSUE #4266]InterruptedExceptions should never be ignored[connectors] #4314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d0ecdf
[ISSUE #4266]: Retore interrupted state for interrupted exception in …
Ruhshan Aug 1, 2023
9a2e60e
[ISSUE #4266]: Retore interrupted state for interrupted exception in …
Ruhshan Aug 1, 2023
e137ad4
[ISSUE #4266]: Retore interrupted state for interrupted exception in …
Ruhshan Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...org/apache/eventmesh/connector/openfunction/sink/connector/OpenFunctionSinkConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ public void put(List<ConnectRecord> sinkRecords) {
try {
queue.put(connectRecord);
} catch (InterruptedException e) {
throw new RuntimeException(e);
Thread currentThread = Thread.currentThread();
log.warn("[OpenFunctionSinkConnector] Interrupting thread {} due to exception {}",
currentThread.getName(), e.getMessage());
currentThread.interrupt();
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions ...apache/eventmesh/connector/openfunction/source/connector/OpenFunctionSourceConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ public List<ConnectRecord> poll() {
}
connectRecords.add(connectRecord);
} catch (InterruptedException e) {
// nothing to do
break;
Thread currentThread = Thread.currentThread();
log.warn("[OpenFunctionSourceConnector] Interrupting thread {} due to exception {}",
currentThread.getName(), e.getMessage());
currentThread.interrupt();
}
}
return connectRecords;
Expand Down
5 changes: 5 additions & 0 deletions ...in/java/org/apache/eventmesh/connector/rocketmq/sink/connector/RocketMQSinkConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ public void put(List<ConnectRecord> sinkRecords) {
Message message = convertRecordToMessage(connectRecord);
try {
SendResult sendResult = producer.send(message);
} catch (InterruptedException e) {
Thread currentThread = Thread.currentThread();
log.warn("[RocketMQSinkConnector] Interrupting thread {} due to exception {}",
currentThread.getName(), e.getMessage());
currentThread.interrupt();
} catch (Exception e) {
log.error("[RocketMQSinkConnector] sendResult has error : ", e);
}
Expand Down