[ISSUE #4266]InterruptedExceptions should never be ignored[connectors]#4314
Merged
mxsm merged 3 commits intoapache:masterfrom Aug 2, 2023
Merged
[ISSUE #4266]InterruptedExceptions should never be ignored[connectors]#4314mxsm merged 3 commits intoapache:masterfrom
mxsm merged 3 commits intoapache:masterfrom
Conversation
…on in open function sinc connector
…on in open function source connector
…on in RocketMQSink connector
Contributor
|
I think log.error() should be used instead of log.warn(). |
Codecov Report
@@ Coverage Diff @@
## master #4314 +/- ##
============================================
- Coverage 16.35% 16.34% -0.01%
Complexity 1359 1359
============================================
Files 594 594
Lines 25419 25415 -4
Branches 2394 2380 -14
============================================
- Hits 4158 4155 -3
Misses 20838 20838
+ Partials 423 422 -1 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
approved these changes
Aug 2, 2023
mxsm
approved these changes
Aug 2, 2023
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…ectors] (apache#4314) * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in open function sinc connector * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in open function source connector * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in RocketMQSink connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4266 .
Motivation
Interrupted exception should never be ignored in the code
Modifications
Restored interrupted state for interrupted exception in the mentioned files in the issue.
Documentation