Minor: use upstream dialect_from_str#6616
Merged
alamb merged 1 commit intoapache:mainfrom Jun 9, 2023
Merged
Conversation
Contributor
Author
|
@yjshen I wonder if you have a few moments to review this PR? |
yjshen
approved these changes
Jun 9, 2023
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
This was upstreamed in apache/datafusion-sqlparser-rs#848, let's use the upstream version
What changes are included in this PR?
use upstream version of a function
Are these changes tested?
existing tests
Are there any user-facing changes?