Skip to content

Add dialect_from_str and improve Dialect documentation#848

Merged
alamb merged 3 commits intoapache:mainfrom
alamb:alamb/parse_dialect
Apr 27, 2023
Merged

Add dialect_from_str and improve Dialect documentation#848
alamb merged 3 commits intoapache:mainfrom
alamb:alamb/parse_dialect

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Apr 10, 2023

In DataFusion we wanted to be able to dynamically pick the dialect. @yjshen added code to do in apache/datafusion#5868

This PR ports the code from DataFusion upstream to sqlparser-rs as well as improves the documentation of Dialect in general

@coveralls
Copy link

coveralls commented Apr 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4660576615

  • 36 of 45 (80.0%) changed or added relevant lines in 2 files are covered.
  • 262 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 86.312%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 262 10.0%
Totals Coverage Status
Change from base Build 4659102766: 0.03%
Covered Lines: 13948
Relevant Lines: 16160
💛 - Coveralls

ankrgyl
ankrgyl reviewed Apr 10, 2023
View reviewed changes
src/dialect/mod.rs
assert!(parse_dialect("bigquery").is::<BigQueryDialect>());
assert!(parse_dialect("BigQuery").is::<BigQueryDialect>());
assert!(parse_dialect("ansi").is::<AnsiDialect>());
assert!(parse_dialect("ANSI").is::<AnsiDialect>());
Copy link
Contributor

@ankrgyl ankrgyl Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there were a way for us to throw a compile error if one of the dialects isn't tested here (or alternatively, loop through a list of dialects and roundtrip them or something to make sure each one is represented).

Copy link
Contributor Author

@alamb alamb Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that would be great.

The only thing I can think of is to make an enum or something with all the dialects 🤔

@alamb alamb mentioned this pull request Apr 10, 2023
Merged
@alamb alamb merged commit 5ecf633 into apache:main Apr 27, 2023
@alamb alamb deleted the alamb/parse_dialect branch June 9, 2023 16:29
@alamb alamb mentioned this pull request Jun 9, 2023
Merged
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@iskakaushik @AviRaboah
@pawel-big-lebowski @alamb @aljazerzen @aprimadi @okue @ankane @mustafasrepo @Jefffrey @max-sixty @eitsupi @mobuchowski @berkaysynnada @ozankabak @dependabot
Merge Upstream (apache#6)
52482b3 
* Support identifiers beginning with digits in MySQL (apache#856)

* support COPY INTO in snowflake (apache#841)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>

* Add `dialect_from_str` and improve `Dialect` documentation (apache#848)

* Add `dialect_from_str` and improve `Dialect` documentation

* cleanup

* fix compilation with nostd

* Support multiple-table DELETE syntax (apache#855)

* Support `DISTINCT ON (...)` (apache#852)

* Support "DISTINCT ON (...)"

* a test

* fix the merge

* Test trailing commas (apache#859)

* test: add tests for trailing commas

* tweaks

* Add support for query source in COPY .. TO statement (apache#858)

* Add support for query source in COPY .. TO statement

* Fix compile error

* Fix logical merge conflict (apache#865)

* Fix tiny typo in custom_sql_parser.md (apache#864)

* Make Expr::Interval its own struct (apache#872)

* Make Expr::Interval its own struct

* Add test interval display

* Fix cargo fmt

* Include license file in published crate (apache#871)

* Add support for multiple expressions, order by in aggregations (apache#879)

* Add support for multiple expressions, order by in aggregations

* Fix formatting errors

* Resolve linter errors

* Add parse_multipart_identifier function to parser (apache#860)

* Add parse_multipart_identifier function to parser

* Update doc for parse_multipart_identifier

* Fix conflict

* feat: Add custom operator (apache#868)

* feat: Add custom operator

From apache#863

- It doesn't parse anything — I'm not sure how to parse ` SELECT 'a' REGEXP '^[a-d]';` with `REGEXP` as the operator... (but fine for my narrow purpose)
- If we need tests, where would I add them?

* Update src/ast/operator.rs

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* feat: Support MySQL's `DIV` operator (apache#876)

* feat: MySQL's DIV operator

* fix: do not use `_` prefix for used variable

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* truncate: table as optional keyword (apache#883)

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>

* feat: add DuckDB dialect (apache#878)

* feat: add DuckDB dialect

* formatting

* fix conflict

* support // in GenericDialect

* add DucDbDialect to all_dialects

* add comment from suggestion

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* fix: support // in GenericDialect

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* Add support for first, last aggregate function parsing (apache#882)

* Add order by parsing to functions

* Fix doc error

* minor changes

* Named window frames (apache#881)

* after over clause, named window can be parsed with window ... as after having clause

* Lint errors are fixed

* Support for multiple windows

* fix lint errors

* simplifications

* rename function

* Rewrite named window search in functional style

* Test added and some minor changes

* Minor changes on tests and namings, and semantic check is removed

---------

Co-authored-by: Mustafa Akur <mustafa.akur@synnada.ai>
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>

* Fix merge conflict (apache#885)

* Update CHANGELOG for `0.34.0` release (apache#884)

* chore: Release sqlparser version 0.34.0

* Update criterion requirement from 0.4 to 0.5 in /sqlparser_bench (apache#890)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: AviRaboah <91826424+AviRaboah@users.noreply.github.com>
Co-authored-by: pawel.leszczynski <leszczynski.pawel@gmail.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Aljaž Mur Eržen <aljazerzen@users.noreply.github.com>
Co-authored-by: Armin Primadi <aprimadi@gmail.com>
Co-authored-by: Okue <nogideca@gmail.com>
Co-authored-by: Andrew Kane <acekane1@gmail.com>
Co-authored-by: Mustafa Akur <106137913+mustafasrepo@users.noreply.github.com>
Co-authored-by: Jeffrey <22608443+Jefffrey@users.noreply.github.com>
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Co-authored-by: Berkay Şahin <124376117+berkaysynnada@users.noreply.github.com>
Co-authored-by: Mustafa Akur <mustafa.akur@synnada.ai>
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ankrgyl ankrgyl ankrgyl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb @coveralls @ankrgyl