Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 75.28% 75.26% -0.03%
==========================================
Files 147 153 +6
Lines 24868 25542 +674
==========================================
+ Hits 18723 19223 +500
- Misses 6145 6319 +174
Continue to review full report at Codecov.
|
Contributor
|
@Dandandan do you still plan to work on this PR? |
Member
|
@Dandandan let me know if you need help with some of the todo list items, happy to help push this PR forward. |
Contributor
|
Closing stale PRs to keep PR review list manageable. Please reopen if that is a mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #440
TODO:
eggdependency) an optional (off by default) feature.inbetweenRationale for this change
See #440 for a longer explanation.
I believe using a optimization library is a great way to accelerate developing & increase the number of optimizations possible.
Also, the more optimizations we add, the more we end up building a own (probably worse) version of a optimization framework.
What changes are included in this PR?
Adds a new optimizer
Tokomakthat does expression simplification based on rewrite rules.Are there any user-facing changes?