Skip to content

chore: rows_to_array cleanup for expecting single field #24040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilconway merged 1 commit into from
Aug 1, 2026
+7 −2
Merged

chore: rows_to_array cleanup for expecting single field #24040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions datafusion/physical-plan/src/aggregates/group_values/multi_group_by/row_backed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,13 @@ impl RowsGroupColumn {
.row_converter
.convert_rows(rows)
.expect("row conversion during emit");
debug_assert_eq!(arrays.len(), 1, "single-field row converter");
let array = arrays.swap_remove(0);
assert_eq!(
arrays.len(),
1,
"Single field row converter must produce exactly one array, actual length is {}",

@neilconway neilconway Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: when the assert fails, it will already print the values, so "actual length is ..." is redundant.

arrays.len()
);
let array = arrays.pop().unwrap();
encode_array_if_necessary(&array, &self.output_type)
.expect("dictionary re-encode during emit")
}
Expand Down
Loading