chore: rows_to_array cleanup for expecting single field - #24040
Merged
neilconway merged 1 commit intoAug 1, 2026
Merged
Conversation
saadtajwar
marked this pull request as ready for review
August 1, 2026 01:52
Contributor
Author
|
@kosiew ready for review! 😄 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24040 +/- ##
==========================================
- Coverage 80.85% 80.85% -0.01%
==========================================
Files 1101 1101
Lines 375467 375469 +2
Branches 375467 375469 +2
==========================================
- Hits 303596 303585 -11
- Misses 53777 53786 +9
- Partials 18094 18098 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
neilconway
approved these changes
Aug 1, 2026
neilconway
left a comment
Contributor
There was a problem hiding this comment.
Nit: the PR prefix should be "chore", not "fix" (which is for bugfixes).
Otherwise lgtm!
| assert_eq!( | ||
| arrays.len(), | ||
| 1, | ||
| "Single field row converter must produce exactly one array, actual length is {}", |
Contributor
There was a problem hiding this comment.
Nit: when the assert fails, it will already print the values, so "actual length is ..." is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Making the
rows_to_arraymethod inRowsGroupColumnbehavior of expecting a singular field explicit, as before it used a generic vector operation ofswap_remove(0)and adebug_assert_eq!for ensuring that there was only a single field extractedWhat changes are included in this PR?
Changed the
debug_assert_eq!to the non-debug macro with a clear error message & changing theswap_remove(0)to apopwithunwrapnow that we are guaranteeing the invariantAre these changes tested?
Yes
Are there any user-facing changes?
No