Derive AggregateUDFImpl equality, hash from Eq, Hash traits#17130
Merged
findepi merged 1 commit intoapache:mainfrom Aug 12, 2025
Merged
Derive AggregateUDFImpl equality, hash from Eq, Hash traits#17130findepi merged 1 commit intoapache:mainfrom
AggregateUDFImpl equality, hash from Eq, Hash traits#17130findepi merged 1 commit intoapache:mainfrom
Conversation
fb676be to
8bf3c5d
Compare
Follows similar change for `WindowUDFImpl`, i.e. the 8494a39 commit. Previously, the `AggregateUDFImpl` trait contained `equals` and `hash_value` methods with contracts following the `Eq` and `Hash` traits. However, the existence of default implementations of these methods made it error-prone, with many functions (scalar, aggregate, window) missing to customize the equals even though they ought to. There is no fix to this that's not an API breaking change, so a breaking change is warranted. Removing the default implementations would be enough of a solution, but at the cost of a lot of boilerplate needed in implementations. Instead, this removes the methods from the trait, and reuses `DynEq`, `DynHash` traits used previously only for physical expressions. This allows for functions to provide their implementations using no more than `#[derive(PartialEq, Eq, Hash)]` in a typical case.
8bf3c5d to
0671ef6
Compare
timsaucer
approved these changes
Aug 12, 2025
Member
timsaucer
left a comment
There was a problem hiding this comment.
Since all of the previous work has already merged, this PR is very simple and easy to follow. Thank you for all the work on this!
Contributor
|
Looks good to me too -- thanks @findepi and @timsaucer |
findepi
added a commit
to findepi/datafusion
that referenced
this pull request
Aug 13, 2025
…e#17130) Follows similar change for `WindowUDFImpl` and `AggregateUDFImpl`, i.e. the 8494a39 and b8bf7c5 commits. Previously, the `ScalarUDFImpl` trait contained `equals` and `hash_value` methods with contracts following the `Eq` and `Hash` traits. However, the existence of default implementations of these methods made it error-prone, with many functions (scalar, aggregate, window) missing to customize the equals even though they ought to. There is no fix to this that's not an API breaking change, so a breaking change is warranted. Removing the default implementations would be enough of a solution, but at the cost of a lot of boilerplate needed in implementations. Instead, this removes the methods from the trait, and reuses `DynEq`, `DynHash` traits used previously only for physical expressions. This allows for functions to provide their implementations using no more than `#[derive(PartialEq, Eq, Hash)]` in a typical case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows similar change for
WindowUDFImpl, i.e. the 8494a39 commit.Previously, the
AggregateUDFImpltrait containedequalsandhash_valuemethods with contracts following theEqandHashtraits. However, the existence of default implementations of these methods made it error-prone, with many functions (scalar, aggregate, window) missing to customize the equals even though they ought to. There is no fix to this that's not an API breaking change, so a breaking change is warranted.Removing the default implementations would be enough of a solution, but at the cost of a lot of boilerplate needed in implementations.
Instead, this removes the methods from the trait, and reuses
DynEq,DynHashtraits used previously only for physical expressions. This allows for functions to provide their implementations using no more than#[derive(PartialEq, Eq, Hash)]in a typical case.WindowUDFImplequality, hash fromEq,Hashtraits #17081AggregateUDFImpl) #16869AggregateUDFImpl::{equals,hash_value}withUdfHash,UdfEqtraits #16872