Derive WindowUDFImpl equality, hash from Eq, Hash traits#17081
Merged
findepi merged 7 commits intoapache:mainfrom Aug 11, 2025
Merged
Derive WindowUDFImpl equality, hash from Eq, Hash traits#17081findepi merged 7 commits intoapache:mainfrom
WindowUDFImpl equality, hash from Eq, Hash traits#17081findepi merged 7 commits intoapache:mainfrom
Conversation
4e26aaa to
b6fcc88
Compare
WindowUDFImpl equality, hash from Eq, Hash traits
c50b82d to
58c1e4f
Compare
alamb
reviewed
Aug 8, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @findepi -- I think the code is looking good here
The only thing I think is missing is some additional documentation in the Upgrading.md guide to explain to people upgrading what they will need to do (add PartialEq and Eq derivation to their functions, right?)
Member
Author
|
The dependency PRs have been merged, will rebase |
Use `DynEq` and `DynHash` traits from physical expressions crate to a common crate for physical and logical expressions. This allows them to be used by logical expressions.
Previously, the `WindowUDFImpl` trait contained `equals` and `hash_value` methods with contracts following the `Eq` and `Hash` traits. However, the existence of default implementations of these methods made it error-prone, with many functions (scalar, aggregate, window) missing to customize the equals even though they ought to. There is no fix to this that's not an API breaking change, so a breaking change is warranted. Removing the default implementations would be enough of a solution, but at the cost of a lot of boilerplate needed in implementations. Instead, this removes the methods from the trait, and reuses `DynEq`, `DynHash` traits used previously only for physical expressions. This allows for functions to provide their implementations using no more than `#[derive(PartialEq, Eq, Hash)]` in a typical case.
58c1e4f to
ab03a96
Compare
xudong963
reviewed
Aug 11, 2025
xudong963
approved these changes
Aug 11, 2025
kosiew
reviewed
Aug 11, 2025
Contributor
kosiew
left a comment
There was a problem hiding this comment.
Left some comments for your consideration.
Wrong Any was compared
alamb
approved these changes
Aug 11, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @findepi @xudong963 and @kosiew
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Member
Author
|
All comments addressed. Thank you @alamb @xudong963 @timsaucer @kosiew for your diligent reviews! |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
WindowUDFImpltrait containedequalsandhash_valuemethods with contracts following theEqandHashtraits. However, the existence of default implementations of these
methods made it error-prone, with many functions (scalar, aggregate,
window) missing to customize the equals even though they ought to.
There is no fix to this that's not an API breaking change, so a breaking
change is warranted.
Removing the default implementations would be enough of a solution, but
at the cost of a lot of boilerplate needed in implementations.
Instead, this removes the methods from the trait, and reuses
DynEq,DynHashtraits used previously only for physical expressions. Thisallows for functions to provide their implementations using no more than
#[derive(PartialEq, Eq, Hash)]in a typical case.WindowUDFImpl) #16870WindowUDFImpl::{equals,hash_value}withUdfHash,UdfEqtraits #16873