Skip to content

Temporarily pin toolchain version to avoid clippy errors#11655

Merged
alamb merged 1 commit intoapache:mainfrom
findepi:findepi/temporarily-pin-toolchain-version-to-avoid-clippy-fde0e5
Jul 25, 2024
Merged

Temporarily pin toolchain version to avoid clippy errors#11655
alamb merged 1 commit intoapache:mainfrom
findepi:findepi/temporarily-pin-toolchain-version-to-avoid-clippy-fde0e5

Conversation

@findepi
Copy link
Member

@findepi findepi commented Jul 25, 2024

Temporarily pin toolchain version until we solve problems reported by newer clippy release.

Closes for #11651

Temporarily pin toolchain version until we solve problems reported by
newer clippy release.
@findepi findepi force-pushed the findepi/temporarily-pin-toolchain-version-to-avoid-clippy-fde0e5 branch from 8c4c5c4 to f44836f Compare July 25, 2024 18:52
@findepi
Copy link
Member Author

findepi commented Jul 25, 2024

@alamb @jayzhan211 @comphead
this may be merge-able as a stop-gap. please review

(and #11654 may become a full fix)

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you (very much) @findepi

I filed #11657 to track removing this stop gap measure and updated this PR to close the ticket (as it fixes the issue reported on the issue)

@alamb alamb changed the title Temporarily pin toolchain version to avoid clippy Temporarily pin toolchain version to avoid clippy errors Jul 25, 2024
@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Merging this in to get main green again

@alamb alamb merged commit 5b7e0aa into apache:main Jul 25, 2024
@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Thanks again @findepi

@findepi findepi deleted the findepi/temporarily-pin-toolchain-version-to-avoid-clippy-fde0e5 branch July 25, 2024 19:48
alamb added a commit to alamb/datafusion that referenced this pull request Jul 25, 2024
comphead pushed a commit that referenced this pull request Jul 26, 2024
…t tests (#11661)

* Revert "Temporarily pin toolchain version to avoid clippy (#11655)"

This reverts commit 5b7e0aa.

* Add ticket references in comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments