Merged
Conversation
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Member
Author
|
Cherry picked #11467 and rebased it on current main. |
Newest version of clippy complains when list item continuation is not indented.
Reported by clippy
To be revisited
This was referenced Jul 25, 2024
This was referenced Jul 25, 2024
alamb
approved these changes
Jul 25, 2024
| ---- | ||
| 131072 | ||
|
|
||
| # FIXME(#TODO) fails with feature `force_hash_collisions` |
Contributor
There was a problem hiding this comment.
I think the concern on #11467 was that this masks a real bug.
However, what I think we should do is file a PR to investigate / restore the tests which I will do so shortly
Contributor
There was a problem hiding this comment.
Suggested change
| # FIXME(#TODO) fails with feature `force_hash_collisions` | |
| # FIXME(#TODO) fails with feature `force_hash_collisions` | |
| # https://github.com/apache/datafusion/issues/11660 |
| } | ||
|
|
||
| // FIXME(#TODO) test fails with feature `force_hash_collisions` | ||
| #[cfg(not(feature = "force_hash_collisions"))] |
Contributor
There was a problem hiding this comment.
Suggested change
| #[cfg(not(feature = "force_hash_collisions"))] | |
| // https://github.com/apache/datafusion/issues/11658 | |
| #[cfg(not(feature = "force_hash_collisions"))] |
|
|
||
| /// Test where the left has 2 parts, the right with 1 part => 1 part | ||
| // FIXME(#TODO) test fails with feature `force_hash_collisions` | ||
| #[cfg(not(feature = "force_hash_collisions"))] |
Contributor
There was a problem hiding this comment.
Suggested change
| #[cfg(not(feature = "force_hash_collisions"))] | |
| // https://github.com/apache/datafusion/issues/11658 | |
| #[cfg(not(feature = "force_hash_collisions"))] |
| } | ||
|
|
||
| /// Test where the left has 1 part, the right has 2 parts => 2 parts | ||
| // FIXME(#TODO) test fails with feature `force_hash_collisions` |
Contributor
There was a problem hiding this comment.
Suggested change
| // FIXME(#TODO) test fails with feature `force_hash_collisions` | |
| // FIXME(#TODO) test fails with feature `force_hash_collisions` | |
| // https://github.com/apache/datafusion/issues/11658 |
| 44 d 4 44 x 3 | ||
| NULL NULL NULL 55 w 3 | ||
|
|
||
| # FIXME(#TODO) fails with feature `force_hash_collisions` |
Contributor
There was a problem hiding this comment.
Suggested change
| # FIXME(#TODO) fails with feature `force_hash_collisions` | |
| # FIXME(#TODO) fails with feature `force_hash_collisions` | |
| # https://github.com/apache/datafusion/issues/11659 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newest version of clippy complains when list item continuation is not indented.
Fixes #11651
Closes #11467