Skip to content

UI E2E: Clarify HITL e2e helper parameter name and error message #68646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
choo121600 merged 1 commit into from
Jun 17, 2026
+5 −5
Merged

UI E2E: Clarify HITL e2e helper parameter name and error message #68646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/ui/tests/e2e/components/HITLReviewDrawer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export class HITLReviewDrawer {
this.root = page.getByRole("dialog", { name: "Required Actions" });
}

public async expectOpenWith(dagId: string): Promise<void> {
public async expectOpenWith(expectedText: string): Promise<void> {
await expect(this.root).toBeVisible();
await expect(this.root).toContainText(dagId);
await expect(this.root).toContainText(expectedText);
}
}
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/ui/tests/e2e/components/HITLReviewModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export class HITLReviewModal {
this.root = page.getByRole("dialog", { name: "Required Actions" });
}

public async expectOpenWith(dagId: string): Promise<void> {
public async expectOpenWith(expectedText: string): Promise<void> {
await expect(this.root).toBeVisible();
await expect(this.root).toContainText(dagId, { timeout: 60_000 });
await expect(this.root).toContainText(expectedText);
}
}
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/tests/e2e/utils/api/hitl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ export async function setupPendingHITLFlowViaAPI(source: RequestLike, dagId: str
const response = await request.patch(`${baseUrl}/api/v2/dags/${dagId}`, { data: { is_paused: false } });

if (!response.ok()) {
throw new Error(`HITL response failed (${response.status()})`);
throw new Error(`Failed to unpause Dag ${dagId} (${response.status()})`);
}

const { dagRunId } = await apiTriggerDagRun(request, dagId);
Expand Down
Loading