Skip to content

UI E2E: Clarify HITL e2e helper parameter name and error message#68646

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:clarify-ui-e2e-hitl
Jun 17, 2026
Merged

UI E2E: Clarify HITL e2e helper parameter name and error message#68646
choo121600 merged 1 commit into
apache:mainfrom
choo121600:clarify-ui-e2e-hitl

Conversation

@choo121600

Copy link
Copy Markdown
Member

Why

The HITL review page objects named their assertion parameter dagId, but some callers pass a run id instead, so the name misrepresented what the helper actually checks and could mislead anyone reading the specs.

The setup helper's generic "HITL response failed" message also hid which step actually failed, making a failing run harder to diagnose.

and drop the redundant 60s timeout override so the modal assertion uses the default timeout.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 17, 2026
@choo121600
choo121600 marked this pull request as ready for review June 17, 2026 03:34
@choo121600
choo121600 merged commit bf590cc into apache:main Jun 17, 2026
164 checks passed
@choo121600

Copy link
Copy Markdown
Member Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants