Add team_name tag to dag processor metrics for multi-team deployments#68599
Merged
ferruzzi merged 5 commits intoJun 18, 2026
Merged
Conversation
2 tasks
1 task
ferruzzi
force-pushed
the
ferruzzi/multi-team/dag-processing-metrics
branch
from
June 16, 2026 06:32
3050329 to
0cf8036
Compare
Contributor
Author
|
Failing CI is legit, I'll fix it when I get a sec. |
vincbeck
approved these changes
Jun 17, 2026
o-nikolas
approved these changes
Jun 18, 2026
o-nikolas
left a comment
Contributor
There was a problem hiding this comment.
I think this one is okay, since it only affects that multi_team=True path, so by default there will be no impact. But in the future we're probably going to want to optimize this. Some ideas that come to my head:
- Memoizing the the
DagBundleModel.get_team_name(...)call, or creating some - Create a
bundle_name: teammapping/cache like we do in the scheduler - Could also read the bundle to team mapping from config, since it's specified in Airflow config, that would safe the DB round trip (but you'd probably want to still do one of the top two in addition to that).
Contributor
Author
|
That's fair. I'll get this merged so we know it'll be in 3.3.0 and follow up immediately with a cached helper like I did with the scheduler. It should be up today; I'll tag you when it's ready. |
This was referenced Jun 18, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 6 of 6, adding team_name to all metrics when available.
Follow-up to #68108
Can be reviewed/merged in parallel with #68367, #68589, #68593, and #68594
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.