Skip to content

Revert "Explicitly initialize Task SDK Stats in API server lifespan (hardening) #68481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Jun 12, 2026
Merged

Revert "Explicitly initialize Task SDK Stats in API server lifespan (hardening) #68481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions airflow-core/src/airflow/api_fastapi/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,32 +71,8 @@ class _AuthManagerState:
_lock = threading.Lock()


def _initialize_task_sdk_stats() -> None:
"""
Initialize the Task SDK ``Stats`` singleton in the API server process.

Initialization is guarded so a metrics misconfiguration can never prevent the API server
from starting.
"""
try:
from airflow._shared.observability.metrics import stats
from airflow.observability.metrics import stats_utils

stats.initialize(
factory=stats_utils.get_stats_factory(),
export_legacy_names=conf.getboolean("metrics", "legacy_names_on"),
)
except Exception:
log.warning(
"Failed to initialize Task SDK Stats in the API server; metrics emitted through the "
"Task SDK Stats singleton will not be recorded.",
exc_info=True,
)


@asynccontextmanager
async def lifespan(app: FastAPI):
_initialize_task_sdk_stats()
async with AsyncExitStack() as stack:
for route in app.routes:
if isinstance(route, Mount) and isinstance(route.app, FastAPI):
Expand Down
43 changes: 0 additions & 43 deletions airflow-core/tests/unit/api_fastapi/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,46 +168,3 @@ def call_create_auth_manager():
assert call_count == 1

app_module.purge_cached_app()


class TestInitializeTaskSdkStats:
"""
Ensure that stats subsystem is properly initialized in API server.
"""

def test_initializes_task_sdk_stats_with_factory(self):
"""It initializes the Task SDK Stats singleton using the configured factory."""
sentinel_factory = object()
with (
mock.patch("airflow._shared.observability.metrics.stats") as mock_stats,
mock.patch(
"airflow.observability.metrics.stats_utils.get_stats_factory",
return_value=sentinel_factory,
) as mock_get_factory,
):
app_module._initialize_task_sdk_stats()

mock_get_factory.assert_called_once_with()
mock_stats.initialize.assert_called_once()
_, kwargs = mock_stats.initialize.call_args
assert kwargs["factory"] is sentinel_factory
assert isinstance(kwargs["export_legacy_names"], bool)

def test_stats_failure_does_not_block_startup(self, caplog):
"""A metrics misconfiguration must not prevent the API server from starting."""
with (
mock.patch("airflow._shared.observability.metrics.stats") as mock_stats,
mock.patch("airflow.observability.metrics.stats_utils.get_stats_factory"),
):
mock_stats.initialize.side_effect = RuntimeError("boom")

# Must not raise.
app_module._initialize_task_sdk_stats()

assert any("Failed to initialize Task SDK Stats" in rec.message for rec in caplog.records)

def test_stats_initialized_during_lifespan(self, client):
"""_initialize_task_sdk_stats must be called as part of the app lifespan, not just defined."""
with mock.patch.object(app_module, "_initialize_task_sdk_stats") as mock_init:
with client():
mock_init.assert_called_once()
Loading