Revert "Explicitly initialize Task SDK Stats in API server lifespan (hardening)#68481
Merged
Merged
Conversation
…hardenin…" This reverts commit 38c50f5.
ashb
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
June 12, 2026 20:16
1 task
Member
Author
|
The underlying change might be okay, but
|
bugraoz93
approved these changes
Jun 12, 2026
pierrejeambrun
approved these changes
Jun 12, 2026
Contributor
|
@ash I can acknowledge a bad PR but here you also make a bad PR yourself. There was no newsfragment, that was earlier in the original PR and was removed on request. |
1 task
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Jun 16, 2026
…hardenin…" (apache#68481) This reverts commit 38c50f5.
dingo4dev
pushed a commit
to dingo4dev/airflow
that referenced
this pull request
Jun 16, 2026
…hardenin…" (apache#68481) This reverts commit 38c50f5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 38c50f5.
It initializes something about Task SDK so that metrics emitted via airflow.sdk path in the API server are emitted correctly.
But nothing in the API server context should be using that -- this is allowing both a bug and an architectural violation.