Skip to content

Update files in prevent deprecated sqlalchemy prek hook #60692

Merged
shahar1 merged 2 commits intoapache:mainfrom
Prab-27:update-prek-hook-files
Jan 31, 2026
Merged

Update files in prevent deprecated sqlalchemy prek hook #60692
shahar1 merged 2 commits intoapache:mainfrom
Prab-27:update-prek-hook-files

Conversation

@Prab-27
Copy link
Copy Markdown
Contributor

@Prab-27 Prab-27 commented Jan 17, 2026

Related : here
and here

closes : #59402 and #45461


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Prab-27 Prab-27 force-pushed the update-prek-hook-files branch from 77f297c to eaa3b01 Compare January 20, 2026 13:05
@Prab-27 Prab-27 marked this pull request as ready for review January 20, 2026 13:06
@Prab-27 Prab-27 force-pushed the update-prek-hook-files branch from eaa3b01 to bcd9190 Compare January 20, 2026 13:46
@Prab-27
Copy link
Copy Markdown
Contributor Author

Prab-27 commented Jan 20, 2026

I only included modules that have python files , Do I need to chnage any module that are not using SQLAlchemy - sessions ?

@shahar1 shahar1 force-pushed the update-prek-hook-files branch from bcd9190 to d9336d7 Compare January 31, 2026 09:57
@Prab-27
Copy link
Copy Markdown
Contributor Author

Prab-27 commented Jan 31, 2026

Thanks @shahar1 for approval !

Some Tests are failing .... Looking into it !

@shahar1
Copy link
Copy Markdown
Contributor

shahar1 commented Jan 31, 2026

Thanks @shahar1 for approval !

Some Tests are failing .... Looking into it !

Anytime :)
Not sure if it's related to these changes though, probably related to the existing ci/cd issues reported on the Slack channel.

@Prab-27
Copy link
Copy Markdown
Contributor Author

Prab-27 commented Jan 31, 2026

@shahar1 , Yes !! That's true

@shahar1 shahar1 force-pushed the update-prek-hook-files branch from d9336d7 to 96babf2 Compare January 31, 2026 13:30
@shahar1
Copy link
Copy Markdown
Contributor

shahar1 commented Jan 31, 2026

@shahar1 , Yes !! That's true

I think it should have been fixed.
Rebased, hopefully it will pass this time.

@Prab-27
Copy link
Copy Markdown
Contributor Author

Prab-27 commented Jan 31, 2026

All green !!!

@shahar1 shahar1 merged commit bc22a99 into apache:main Jan 31, 2026
71 checks passed
@github-actions
Copy link
Copy Markdown

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker bc22a99 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

morelgeorge pushed a commit to morelgeorge/airflow that referenced this pull request Feb 1, 2026
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated Query usage and update to SQLAlchemy2.0 style

2 participants