Skip to content

Update prek hook to check for session.query()#60510

Merged
potiuk merged 1 commit intoapache:mainfrom
Prab-27:update-prek-hook-check-session
Jan 14, 2026
Merged

Update prek hook to check for session.query()#60510
potiuk merged 1 commit intoapache:mainfrom
Prab-27:update-prek-hook-check-session

Conversation

@Prab-27
Copy link
Copy Markdown
Contributor

@Prab-27 Prab-27 commented Jan 14, 2026

Related discussion : here and here

From now on, this also checks for the entire session.query() usage, so we can remove it from the remaining providers

Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk merged commit 62f2804 into apache:main Jan 14, 2026
63 checks passed
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jan 14, 2026

nice!

github-actions bot pushed a commit that referenced this pull request Jan 14, 2026
(cherry picked from commit 62f2804)

Co-authored-by: Pratiksha <128999446+Prab-27@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

@jscheffl
Copy link
Copy Markdown
Contributor

There is also a looong list in pre-merge checks for Prevent deprecated sqlalchemy usage - can this also be cleaned if we are on it?

@Prab-27
Copy link
Copy Markdown
Contributor Author

Prab-27 commented Jan 15, 2026

There is also a looong list in pre-merge checks for Prevent deprecated sqlalchemy usage - can this also be cleaned if we are on it?

Yes, I’ll do that once we’ve cleaned up the entire module. I’ll update it then.

We’re almost done here — just a few tasks left, and after that we can customize this.

Here’s the TODO: #47275 (comment) .

I’d love to hear from you !!

@jscheffl
Copy link
Copy Markdown
Contributor

I’d love to hear from you !!

Cool! No all fine. I am not an expert but a noob in this. I am grateful that you are leading this!
Maybe you make a PR which is expected to fail and when ever you rebase you see how much is missing... once it turns green merge it.
I am trying the same with enabling Ruff rule PLW0603 in #58116 which also is a long path...

ephraimbuddy pushed a commit that referenced this pull request Jan 16, 2026
(cherry picked from commit 62f2804)

Co-authored-by: Pratiksha <128999446+Prab-27@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Jan 16, 2026
(cherry picked from commit 62f2804)

Co-authored-by: Pratiksha <128999446+Prab-27@users.noreply.github.com>
@Prab-27
Copy link
Copy Markdown
Contributor Author

Prab-27 commented Jan 16, 2026

I’d love to hear from you !!

Cool! No all fine. I am not an expert but a noob in this. I am grateful that you are leading this! Maybe you make a PR which is expected to fail and when ever you rebase you see how much is missing... once it turns green merge it. I am trying the same with enabling Ruff rule PLW0603 in #58116 which also is a long path...

It helps me a lot! I really appreciate this idea!!

jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants