Fix deferrable mode for BeamRunPythonPipelineOperator#44386
Merged
eladkal merged 1 commit intoapache:mainfrom Nov 27, 2024
Merged
Fix deferrable mode for BeamRunPythonPipelineOperator#44386eladkal merged 1 commit intoapache:mainfrom
eladkal merged 1 commit intoapache:mainfrom
Conversation
Contributor
Do we have a way to verify if other operators / other providers suffer from this problem? If so, lets open dedicated issues for them so we can keep track on it. |
Contributor
Author
To be honest I do not see any way how we can check the existence of this problem for other operators/providers. |
eladkal
approved these changes
Nov 27, 2024
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 28, 2024
2 tasks
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have prepared a fix for an error in deferrable mode for
BeamRunPythonPipelineOperator.This error happens on a distributed system when the user has
triggerandworkeron different machines.BeamRunPythonPipelineOperatorneeds a localpyfile for starting a Job. Users can specify a path to thepyfile which is located in GCS bucket and then the operator will download this file to the local system. In the current deferrable mode implementation operator downloadspyfile before going to the deferrable mode. It means that on a distributed system the file is downloaded on theworkermachine not on thetriggermachine. And then when the operator tries to execute a Job on thetriggermachine Airflow throws an error that the executablepyfile does not exist.Fix for the same issue for the
BeamRunJavaPipelineOperator: #39371^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.