Fix deferrable mode for BeamRunJavaPipelineOperator#39371
Merged
Lee-W merged 1 commit intoapache:mainfrom May 14, 2024
Merged
Conversation
9e144be to
14e4629
Compare
Contributor
potiuk
reviewed
May 9, 2024
14e4629 to
6361ef4
Compare
Contributor
Author
potiuk
approved these changes
May 14, 2024
Lee-W
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have prepared a fix for an error in deferrable mode for
BeamRunJavaPipelineOperator.This error happens on a distributed system when the user has
triggerandworkeron different machines.BeamRunJavaPipelineOperatorneeds a localjarfile for starting a Job. Users can specify a path tojarfile which is located in GCS bucket and then the operator will download this file to the local system. In the current deferrable mode implementation operator downloadsjarfile before going to the deferrable mode. It means that on a distributed system the file is downloaded on theworkermachine not on thetriggermachine. And then when the operator tries to execute a Job on thetriggermachine Airflow throws an error that the executablejarfile does not exist.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.