Use upload_files_v2 Slack SDK method by default in Slack Operators#39340
Merged
eladkal merged 1 commit intoapache:mainfrom May 1, 2024
Merged
Conversation
upload_files_v2 Slack SDK method by default in Slack Operators
07e8973 to
cc25d71
Compare
cc25d71 to
7d6b804
Compare
eladkal
approved these changes
May 1, 2024
amoghrajesh
reviewed
May 1, 2024
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Late to the party, looks good +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple days ago Slack sent auto message to my my email which informed me that
files.uploaddiscontinued soonLink for more details about upcoming changes: https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay
Recently we add support of
v2method #36757, and also addSlackHook.send_file_v1_to_v2for smooth transition betweenv1andv2which used in operators under the hoodSo I would propose to switch by default to
v2:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.