Optionally use client.files_upload_v2 in Slack Provider#36757
Merged
eladkal merged 3 commits intoapache:mainfrom Jan 20, 2024
Merged
Optionally use client.files_upload_v2 in Slack Provider#36757eladkal merged 3 commits intoapache:mainfrom
client.files_upload_v2 in Slack Provider#36757eladkal merged 3 commits intoapache:mainfrom
Conversation
Taragolis
commented
Jan 13, 2024
676527f to
e68be8a
Compare
9301cd6 to
0547dc9
Compare
potiuk
approved these changes
Jan 20, 2024
potiuk
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Optionally use `client.files_upload_v2` in Slack Provider * Revert default value for method * Remove redundand assigment (cherry picked from commit 9758acf)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Optionally use `client.files_upload_v2` in Slack Provider * Revert default value for method * Remove redundand assigment (cherry picked from commit 9758acf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #35034
Default method which we use for upload files into the slack might failed with timeout error or gateway errors in case of upload huge files, for resolve this implement optional ability to switch to
client.files_upload_v2which should resolve this issue.Unfortunetly it is not 100% builtin replacement and required some changes in scope of application, so I keep v1 (
client.files_upload) as default when we consider to bump major version we also could switch default uploader method.In addition some minor (or not) changes into the execute method signature, which doesn't follow
BaseOperatorsignature^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.