Skip to content

style(providers/google): improve BigQueryInsertJobOperator type hinting #36894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 2 commits into from
Jan 20, 2024
Merged

style(providers/google): improve BigQueryInsertJobOperator type hinting #36894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5a9e23
style(providers/google): improve BigQueryInsertJobOperator type hinting
Lee-W Jan 19, 2024
b45943d
style: resolve mypy failure
Lee-W Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion airflow/providers/google/cloud/operators/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2852,6 +2852,7 @@ def execute(self, context: Any):
persist_kwargs["dataset_id"] = table["datasetId"]
persist_kwargs["project_id"] = table["projectId"]
BigQueryTableLink.persist(**persist_kwargs)

self.job_id = job.job_id

if self.project_id:
Expand All @@ -2861,6 +2862,7 @@ def execute(self, context: Any):
location=self.location,
)
context["ti"].xcom_push(key="job_id_path", value=job_id_path)

# Wait for the job to complete
if not self.deferrable:
job.result(timeout=self.result_timeout, retry=self.result_retry)
Expand All @@ -2882,7 +2884,7 @@ def execute(self, context: Any):
self.log.info("Current state of job %s is %s", job.job_id, job.state)
self._handle_job_error(job)

def execute_complete(self, context: Context, event: dict[str, Any]):
def execute_complete(self, context: Context, event: dict[str, Any]) -> str | None:
"""Callback for when the trigger fires.

This returns immediately. It relies on trigger to throw an exception,
Expand Down