Skip to content

style(providers/google): improve BigQueryInsertJobOperator type hinting#36894

Merged
eladkal merged 2 commits intoapache:mainfrom
astronomer:enhance-BigQueryInsertJobOperator-type-hinting
Jan 20, 2024
Merged

style(providers/google): improve BigQueryInsertJobOperator type hinting#36894
eladkal merged 2 commits intoapache:mainfrom
astronomer:enhance-BigQueryInsertJobOperator-type-hinting

Conversation

@Lee-W
Copy link
Copy Markdown
Member

@Lee-W Lee-W commented Jan 19, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 19, 2024
Copy link
Copy Markdown
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type checks are failing. Can you check and address them?

@Lee-W Lee-W force-pushed the enhance-BigQueryInsertJobOperator-type-hinting branch from 96b4b32 to b45943d Compare January 20, 2024 07:56
@Lee-W
Copy link
Copy Markdown
Member Author

Lee-W commented Jan 20, 2024

I think Mypy is not happy about annotating jobs in multiple places 🤔 I Just removed that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants