Table for affected tasks in grid actions#30633
Merged
pierrejeambrun merged 1 commit intoapache:mainfrom Apr 14, 2023
Merged
Conversation
eladkal
approved these changes
Apr 14, 2023
Contributor
|
I just merged #30373 but looks like we need to rebase this one. |
6da7f70 to
9cba57a
Compare
Member
|
(liteally nice :D) |
Member
Author
|
Thanks @bbovenzi, I just rebased it |
bbovenzi
approved these changes
Apr 14, 2023
Contributor
bbovenzi
left a comment
There was a problem hiding this comment.
Task Actions are going to be so much better!
Eventually, we should get rid of the task actions in views.py and only use the REST API
Member
Author
|
Sync PR is already up for 2.6.0. I think this one is a little late to make it, marking for 2.6.1 |
wookiist
pushed a commit
to wookiist/airflow
that referenced
this pull request
Apr 19, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2023
(cherry picked from commit 90ee763)
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #30373, you can only look at the last commit that allows to display the affected task instances in a table for more visibility when performing an action in the grid view.
I wish we could serialize the data using a standardized schema for both
api_connexionandviews. In such case being able to use a sharedTaskInstanceSchemawould be helpful for consistency. I don't think we need many representations of a serialized TaskInstance (or any other object) for the webserver.Right now
api_connexionandviewsare well separated, coupling the two by importing this schema into the view feels wrong but maybe having some shared schema in a parent folder could prove useful. Also at the momentTaskInstanceSchemaworks on a tuple with SLA miss, and cannot dump bare 'TaskInstance' objects which can be an issue when you don't have the sla miss for serialization. (In this case for instance)Before
After