Improve task & run actions ux in grid view#30373
Conversation
|
It seems the popup got narrower, or is it simply a difference in local setup? |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Tested locally works as expected.
The code looks good to me :)
Small nit, we lost a user warning about clearing task group in the past/future informing that this action could take a while. (Due to possible db locks etc). I'm not against removing it but just want to make sure that it was intended to be removed :)
|
I think you are right @uranusjr. I am opening a follow up PR to display a table there for the task detail, I feel like it is really hard to see the tasks in the current code block. Also I just noticed a small thing, buttons are Also weirdly for outlined button, vertical align seems off. |
|
Fixed the different button fill. |
* update run clear+mark, update task clear * add mark as tasks and include list of affected tasks * Add support for mapped tasks, add shared modal component * Clean up styling, restore warning for past/future tg clear (cherry picked from commit c5b685e)
* update run clear+mark, update task clear * add mark as tasks and include list of affected tasks * Add support for mapped tasks, add shared modal component * Clean up styling, restore warning for past/future tg clear
|
This has had some unintended consequences, I've outlined them in issue #31186. |
Closes #29851
Before
After
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.