Refactor Dataproc Trigger#29364
Merged
Merged
Conversation
pankajastro
force-pushed
the
improve_dataproc_trigger
branch
4 times, most recently
from
February 3, 2023 22:13
594b0a4 to
b9d15f7
Compare
pankajastro
marked this pull request as ready for review
February 3, 2023 22:46
Member
Author
|
Hi @potiuk can I get some reveiw on this please? Thank you! |
pankajastro
force-pushed
the
improve_dataproc_trigger
branch
from
February 13, 2023 13:35
b9d15f7 to
26246de
Compare
potiuk
reviewed
Feb 20, 2023
Member
There was a problem hiding this comment.
Just one question - I guess this is in trigger so there are no worries about back-compatibility ?
Member
Author
There was a problem hiding this comment.
yes, I think that is correct.
pankajastro
force-pushed
the
improve_dataproc_trigger
branch
from
February 20, 2023 19:27
26246de to
6fde668
Compare
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.