Add deferrable mode to DataprocInstantiateWorkflowTemplateOperator#28618
Conversation
There was a problem hiding this comment.
does it make sense to extend this class from DataprocBaseTrigger instead of BaseTrigger https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/triggers/dataproc.py#L31 WDYT?
There was a problem hiding this comment.
DataprocBaseTrigger is dedicated to e.g. DataprocSubmitJobOperator.
I changed the name to DataprocSubmitTrigger for clarity.
There was a problem hiding this comment.
@VladaZakharova @bkossakowska somehow I thought this PR has merged so I created #29364 PR to do some refactoring on the trigger and address my above comments.
There was a problem hiding this comment.
merging anyone would cause conflict in others.
There was a problem hiding this comment.
@pankajastro
Okay, no problem!
Do you know when your changes for the trigger will be merged?
97206ce to
b6053e1
Compare
1e3b5ef to
9ce75af
Compare
|
Hi @potiuk, |
Yes. But after I merged the previous one, conflicts need to be resolved here :) |
2154761 to
309944f
Compare
|
@potiuk |
309944f to
7597796
Compare
|
Hi! |
Add deferrable mode to DataprocInstantiateWorkflowTemplateOperator
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.