v2 changes of connector and connector_auth#461
Merged
Conversation
This was referenced Jul 9, 2024
hari-kuriakose
approved these changes
Jul 11, 2024
Contributor
hari-kuriakose
left a comment
There was a problem hiding this comment.
@muhammad-ali-e Models look good. Added couple of comments though.
Code duplication can be ignore for now, as we will delete v1 later.
Also migration files for v2 can be generated later together.
vishnuszipstack
approved these changes
Jul 16, 2024
Contributor
|
|
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* v2 changes of connector and connector_auth * minor changes in import * minor changes in docstring * cascade deletion for connector auth --------- Co-authored-by: Hari John Kuriakose <hari@zipstack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


NOTE
What
Why
How
get_organizationmethod to utilize the user context.apps.py.modelswith updated table names.connector_metadatafield and updatedconnector_metadata_btoconnector_metadata.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.