Version 2 of User/Organization Account Module#431
Conversation
|
I see Some sonar issues,
|
johnyrahul
left a comment
There was a problem hiding this comment.
LGTM overall. As this is v2 of same account app with changes mentioned in description.
Some of it dependent models will be raised as separate PR as author mentioned
|
@muhammad-ali-e One doubt, will we be removing the previous version after the test-runs ? |
@athul-rs We will only remove the previous version once we have fully transitioned to the new feature and all QA checks are completed. Until then, we will keep all V1 applications, including their tables and schema, to ensure continuity and avoid any disruption. |
There was a problem hiding this comment.
LGTM for the overall code.
Only doubt remains on the duplicate code we are adding to OSS, please proceed if this is alright. cc: @hari-kuriakose
|
Bypassing Sonar duplication issue. This is because the Django apps are duplicated purposefully, which is the less messier path. Similarly it's best the models too are separate in order to prevent any conflict with prior logic. Also once we complete the migration, we will remove all the older Django apps. |
|
We can take care of duplication when we delete v1 eventually. Bypassing. |
|
|
* version 2 of user/organization account module * updated reverse foreign keys --------- Co-authored-by: Athul <89829560+athul-rs@users.noreply.github.com> Co-authored-by: Hari John Kuriakose <hari@zipstack.com>


What
Why
How
tenant_context(organization)with newUserContextmethods.StateStoreto store and manage the organization ID in the current context.TenantMixinand redundant methods.OrganizationMixinfor better model structuring.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
multi_tenancy_v2.Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.