Hotfix: Frontera: (UTRC-356) Homepage Banner Bkgd (x-overlay Mixin Syntax)#386
Merged
Merged
Conversation
Affects Frontera and UTRC. Both are updated in this commit. Cherry-picked from: - 17d5174 - `task/GH-93-GH-142-GH-133-article-list-plugins-and-styles--no-reverts`
Bug Source: - #368 - #361 - TACC/Core-CMS-Resources@6d253e1...522c296#diff-5894bbc Cherry-picked from: - d452772 - `task/GH-93-GH-142-GH-133-article-list-plugins-and-styles--no-reverts`
The force-push was to edit last two commits' messages. Annotated each with "cherry-pick", "Hotfix", commit picked, and branch.
.x-overlay-- classesx-overlay Mixin)
x-overlay Mixin)x-overlay Mixin)
x-overlay Mixin)x-overlay Mixin Syntax)
x-overlay Mixin Syntax)x-overlay Mixin Syntax)
Member
Author
|
Merging because:
|
wesleyboar
added a commit
that referenced
this pull request
Oct 27, 2021
x-overlay Mixin Syntax)x-overlay Mixin Syntax)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
x-overlayMixin Syntax) Core-CMS-Resources#102Overview
Fix Frontera home page banner background (looked like UTRC's instead of Frontera's).
Issues
After cloning prod to pre-prod, bugs were found that must be fixed before deploy.
Screenshots
* The width of the banner now matches width of the text beneath. This problem was not noticed in earlier deploy.
Full Page
* The background blur is missing because Edge full page screenshot neglects to render the blur. It is a bug of Edge, not of the webpage.
Testing
Confirm that banner background color and blur in pre-prod match production.
Last Recorded Testable Build:
hotfix/frontera-banner-wrongly-has-utrc-style