Skip to content

Quick: Complete Core fix for section header colors#385

Merged
wesleyboar merged 4 commits into
mainfrom
hotfix/wrong-heading-text-colors-on-home-page
Oct 26, 2021
Merged

Quick: Complete Core fix for section header colors#385
wesleyboar merged 4 commits into
mainfrom
hotfix/wrong-heading-text-colors-on-home-page

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Oct 26, 2021

Copy link
Copy Markdown
Member

Requires

Overview

Set color of headings within a Sections to respect whether section is light or dark.

This is a more complete fix than #384.

Issues

After FP-1252 (cloning prod to pre-prod), this bug was discovered, which must be fixed before FP-1273 (deploy).

Screenshots

Headings are fixed. (Before, white text could appear on white background, or dark text on dark background.)

Pre-Prod Fixed Prod (Goal) Notes
Pre-Prod Prod banner text bkgd†

sysmon badge*

* The banner text background difference is a bug, a known issue, to fix in a separate PR.

† Warning badge for System Monitor maintenance is new orange color. This is a pre-existing fix, not a bug. production is using portal warning color, which Design did declare was for CMS.

Testing

Confirm that heading colors in pre-prod match production.

Last Recorded Testable Build:

@wesleyboar

wesleyboar commented Oct 26, 2021

Copy link
Copy Markdown
Member Author

Merging because:

  1. Frontera CMS may deployed this week, and should not cause such obvious bugs as these. I was only just able to realize these bugs, yesterday, after FP-1252 was completed.
  2. Related fix Hotfix: Frontera: White Text for Home Banner H3's Core-CMS-Resources#100 was merged.
  3. Taking advantage of admin privilege.

Related submod branch was merged to main.
@wesleyboar
wesleyboar merged commit 8b9256b into main Oct 26, 2021
@wesleyboar
wesleyboar deleted the hotfix/wrong-heading-text-colors-on-home-page branch October 26, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant