Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/claude-pr-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,25 @@ jobs:

Remember: Silence is golden. No comment is better than a low-value comment.

## Container Image Accessibility Validation:
When reviewing changes to `.github/configs/*-master.yaml` files, verify that ALL `image:` values are publicly accessible:

**Valid image formats (publicly accessible):**
- Docker Hub: `organization/image:tag` (e.g., `lmsysorg/sglang:v0.5.7-rocm700-mi35x`)
- NGC: `nvcr.io/nvidia/...` or `nvcr.io#nvidia/...` (e.g., `nvcr.io/nvidia/ai-dynamo/tensorrtllm-runtime:0.8.1.post1` or `nvcr.io#nvidia/tensorrt-llm/release:1.1.0rc2.post2`)
- Other public registries: `ghcr.io/...`, `quay.io/...`, `rocm/...`

**Invalid image formats (NOT publicly accessible):**
- generally these images are not best practices to have in:
- Local file paths: `/scratch/...`, `/home/...`, `/data/...`, or any path starting with `/`
- `.sqsh` files (squashfs containers stored locally)
- Internal/private registry paths that are not publicly resolvable

If any `image:` field contains a local path or non-public image:
- This is a 🔴 **BLOCKING** issue
- Comment: "Image must be publicly accessible on NGC, Docker Hub, or another public registry. Local paths like `/scratch/...` or `.sqsh` files are generally not accepted. Please push the container to a public registry (e.g., `nvcr.io/nvidia/...` for NGC) and update the config with the public image reference."
- Link to the specific line with the invalid image path

## vLLM and SGLang Source Code Access:
You have access to vLLM and SGLang source code via the inferencemax-repos MCP server:
- Use `mcp__inferencemax-repos__*` tools to access repository source code
Expand Down