Add container image accessibility validation to PR review#591
Merged
functionstackx merged 3 commits intomainfrom Jan 28, 2026
Merged
Add container image accessibility validation to PR review#591functionstackx merged 3 commits intomainfrom
functionstackx merged 3 commits intomainfrom
Conversation
Adds a new validation rule that requires all images in *-master.yaml config files to be publicly accessible on NGC, Docker Hub, or other public registries. Local file paths (e.g., /scratch/..., .sqsh files) will be flagged as blocking issues since they are not reproducible. Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
Update the container image validation rules to also accept images using the # notation (e.g., nvcr.io#nvidia/tensorrt-llm/release:1.1.0rc2.post2) which is used by some container runtimes like Enroot. Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
Clarified the comment regarding invalid image formats to indicate that local paths and .sqsh files are generally not accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-pr-review.ymlworkflow promptimage:values in.github/configs/*-master.yamlfiles to be publicly accessiblenvcr.io/nvidia/...), Docker Hub (org/image:tag), other public registries/scratch/...),.sqshfiles, non-public registriesWhy
Local container paths are not reproducible and make it difficult for others to run benchmarks. This ensures all benchmark configurations use publicly accessible containers.
Test plan
Requested by @functionstackx in #588
🤖 Generated with Claude Code