polyval: use ManuallyDrop unions; MSRV 1.49+#113
Merged
Conversation
Using `ManuallyDrop` for the fields of `union`s (allowing them to be non-Copy types) was stabilized in Rust 1.49.
253c4cb to
563fa52
Compare
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 50.04% 49.14% -0.91%
==========================================
Files 14 14
Lines 1091 1107 +16
==========================================
- Hits 546 544 -2
- Misses 545 563 +18
Continue to review full report at Codecov.
|
tarcieri
added a commit
that referenced
this pull request
Dec 31, 2020
Using `ManuallyDrop` for the fields of `union`s (allowing them to be non-Copy types) was stabilized in Rust 1.49.
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
ManuallyDropfor the fields ofunions (allowing them to be non-Copy types) was stabilized in Rust 1.49.